Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure listener called in testRegisterRepositorySuccessAfterCreationFailed #108477

Closed
wants to merge 1 commit into from
Closed

Ensure listener called in testRegisterRepositorySuccessAfterCreationFailed #108477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 8 additions & 12 deletions server/src/test/java/org/elasticsearch/repositories/RepositoriesServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.admin.cluster.repositories.put.PutRepositoryRequest;
import org.elasticsearch.action.support.SubscribableListener;
import org.elasticsearch.action.support.master.AcknowledgedResponse;
import org.elasticsearch.cluster.ClusterChangedEvent;
import org.elasticsearch.cluster.ClusterName;
Expand Down Expand Up @@ -283,18 +284,13 @@ public void testRegisterRepositorySuccessAfterCreationFailed() {
// 2. repository creation successfully when current node become master node and repository is put again
var request = new PutRepositoryRequest().name(repoName).type(TestRepository.TYPE);

repositoriesService.registerRepository(request, new ActionListener<>() {
@Override
public void onResponse(AcknowledgedResponse acknowledgedResponse) {
assertTrue(acknowledgedResponse.isAcknowledged());
assertThat(repositoriesService.repository(repoName), isA(TestRepository.class));
}

@Override
public void onFailure(Exception e) {
assert false : e;
}
});
safeAwait(
SubscribableListener.<AcknowledgedResponse>newForked(l -> repositoriesService.registerRepository(request, l))
.andThenAccept(acknowledgedResponse -> {
assertTrue(acknowledgedResponse.isAcknowledged());
assertThat(repositoriesService.repository(repoName), isA(TestRepository.class));
})
);
}

private ClusterState createClusterStateWithRepo(String repoName, String repoType) {
Expand Down