Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] ES|QL implicit casting #108618

Merged
merged 3 commits into from
May 15, 2024
Merged

[DOCS] ES|QL implicit casting #108618

merged 3 commits into from
May 15, 2024
+60 −0

Conversation

fang-xing-esql
Copy link
Contributor

Add docs for implicit casting.

@fang-xing-esql fang-xing-esql added >docs General docs changes auto-backport-and-merge Automatically create backport pull requests and merge when ready :Analytics/ES|QL AKA ESQL v8.14.1 v8.15.0 labels May 14, 2024
@github-actions GitHub Actions
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels May 14, 2024
leemthompo
leemthompo reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @fang-xing-esql, just a few suggestions for clarity and presentation so far :)

We would definitely want to link this page from the type conversion functions section, perhaps in a TIP callout.

docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
@fang-xing-esql
Copy link
Contributor Author

This is looking good @fang-xing-esql, just a few suggestions for clarity and presentation so far :)

We would definitely want to link this page from the type conversion functions section, perhaps in a TIP callout.

Thank you for reviewing Liam! The last commit is updated according to the comments, could you please take another look?

leemthompo
leemthompo reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things, plus let's add link in esql-language.asciidoc, you already have the include statement, but just need link text so it appears in the list on that page :)

Once addressed should be good to go, thank you!

docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/implicit-casting.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/functions/type-conversion-functions.asciidoc Outdated Show resolved Hide resolved
@fang-xing-esql
Copy link
Contributor Author

Couple minor things, plus let's add link in esql-language.asciidoc, you already have the include statement, but just need link text so it appears in the list on that page :)

Once addressed should be good to go, thank you!

Thank you for double checking again @leemthompo ! All of the comments are addressed.

leemthompo
leemthompo approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective. Thanks for iterating!

@fang-xing-esql fang-xing-esql merged commit 172c059 into elastic:main May 15, 2024
5 checks passed
fang-xing-esql added a commit to fang-xing-esql/Elasticsearch that referenced this pull request May 15, 2024
@fang-xing-esql
[DOCS] ES|QL implicit casting (elastic#108618)
8c118eb 
* implicit casting doc
@fang-xing-esql fang-xing-esql mentioned this pull request May 15, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.14

elasticsearchmachine pushed a commit that referenced this pull request May 15, 2024
@fang-xing-esql
[DOCS] ES|QL implicit casting (#108618) (#108677)
6fe457f 
* implicit casting doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.14.1 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fang-xing-esql @elasticsearchmachine @leemthompo