Disallow non-file characters in pipeline names #108648
Conversation
Pipeline names may currently contain several characters non-alpah characters, such as comma and asterisk. Pipelines with such name cannot be fetched by id from the `GET _ingest/pipeline/` api as the comma is interpreted to mean multiple id queries, and the asterisk is treated as a star query. Thus these characters, along with other characters which are not allowed in index or alias names, should be disallowed from pipeline names.
elasticsearchmachine
added
the
needs:triage
parkertimmins
added
>bug
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @parkertimmins, I've created a changelog YAML for you. |
Pipeline.create can be called on existing pipeline. We want existing pipelines with names that contains special characters to continue to function. Thus only validation in put request before making pipeline.
|
Should we consult the Backwards Compatability Committee (BCC) on this? cc @dakrone |
|
This is definitely something we'd want to consider as breaking before merging (and should consult the BCC). Also (separately), I wouldn't consider this large enough to introduce a brand new exception, we could likely use |
|
I was thinking to discuss with the team whether or not this seemed breaking changy, but in that case I'll go ahead and open a BCC ticket. |
Validating pipeline names is not worth creating a new exception, just use IllegalArgumentException .
Pipeline names may currently contain several non-alpha characters, such as comma and asterisk. Pipelines with such names cannot be fetched by id from the
GET _ingest/pipeline/api as the comma is interpreted to mean multiple id queries, and the asterisk is treated as a star query. Thus these characters, along with other characters which are not allowed in index or alias names, should be disallowed from pipeline names.closes #104411