Add bounds checking to parsing ISO8601 timezone offset values #108672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.15.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @thecoop, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
pgomulka
approved these changes
May 15, 2024
| @@ -70,6 +70,9 @@ public void testOutOfRange() { | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:60", null), hasError(14)); | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:59:60", null), hasError(17)); | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:59:59+18:30", null), hasError(19)); | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:59:59+24", null), hasError(19)); | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:59:59+1060", null), hasError(19)); | |||
| assertThat(defaultParser().tryParse("2023-12-31T23:59:59+105960", null), hasError(19)); | |||
There was a problem hiding this comment.
just from the test readability point of view it, would it look better to have +10:59:60?
There was a problem hiding this comment.
I wanted to vary it a bit between timezones with : and those without, thats the only reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we check the bounds of values used for timezone offsets