-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update searchable snapshot to clarify #108750
Conversation
Update searchable snapshot to clarify it's not a backup of index data and deleting it will result in permanent data loss. It's a follow up of #108451
Documentation preview: |
@kunisen please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IME it doesn't work very well to start sections with WARNING
admonitions like this. Maybe one is ok, but then we add another, and another, and it ends up pushing the actual content of the section out of view.
Also, this warning is kind of confusing (what does it have to do with frozen/cold data?) and also kind of ambiguous (deleting the searchable snapshot index does not cause permanent data loss, it's only deleting the underlying snapshot while it's still mounted that causes problems).
Instead, maybe we should make this whole section into a WARNING
, and add some more detail to each of the bullet points in the list about the consequences of ignoring the advice.
Thank you @DaveCTurner so much for the quick and detailed guidance! We are good with this change. If you don't mind, may I also ask your help to see if we can merge this PR, or if you can kindly forward this to doc team for doc-related reviews? 🙏 Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks! |
Relates #108451 Co-authored-by: David Turner <david.turner@elastic.co>
Relates #108451 Co-authored-by: David Turner <david.turner@elastic.co>
gradle check
? Not codeUpdate searchable snapshot to clarify it's not a backup of index data and deleting it will result in permanent data loss.
It's a follow up of #108451