Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector API] Improve create connector endpoints #108766

Merged
merged 1 commit into from
May 17, 2024
Merged

[Connector API] Improve create connector endpoints #108766

merged 1 commit into from
May 17, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented May 17, 2024 •
edited

Changes

  • Since all body params are optional when creating a connector, let's handle empty request body correctly
    • It was reported that people are confused why body always has to be passed (even if empty)
  • Unify create connector API with how index API works when creating new connectors
    • we accept PUT _connector/{id} if id is not provided doc _id is auto-generated
    • for POST _connector request _id is always auto-generated
    • Unify create connector response type
  • Simplify internal connector service logic
  • Add tests empty body, missing id path param
  • Update docs

@jedrazb jedrazb requested a review from efegurkan May 17, 2024 10:59
@github-actions GitHub Actions
Copy link

Documentation preview:

@jedrazb jedrazb added >non-issue :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels May 17, 2024
@jedrazb jedrazb marked this pull request as ready for review May 17, 2024 11:02
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

efegurkan
efegurkan approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A few questions rather for myself to understand.

@jedrazb jedrazb merged commit bb5cac9 into elastic:main May 17, 2024
16 checks passed
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 17, 2024
@jedrazb @parkertimmins
[Connector API] Improve create connector endpoints (elastic#108766)
9851077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
:EnterpriseSearch/Application Enterprise Search >non-issue Team:Enterprise Search Meta label for Enterprise Search team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jedrazb @elasticsearchmachine @efegurkan