Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose x-pack telemetry for failure store #108899

Merged
merged 6 commits into from
May 23, 2024
Merged

Expose x-pack telemetry for failure store #108899

merged 6 commits into from
May 23, 2024

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented May 22, 2024 •
edited
Loading

In this PR we extend the data_streams section in the usage API to include failure store stats. The current structure is:

  "data_streams" : {
    "available" : true,
    "enabled" : true,
    "data_streams" : 0,
    "indices_count" : 0
  }

We propose:

  "data_streams" : {
    "available" : true,
    "enabled" : true,
    "data_streams" : 0,
    "indices_count" : 0,
    "failure_store": {
      "enabled_count": 4,
      "failure_indices_count": 10
    }
  }

@gmarouli gmarouli added >non-issue :Data Management/Data streams Data streams and their lifecycles labels May 22, 2024
@gmarouli gmarouli requested a review from a team as a code owner May 22, 2024 12:32
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v8.15.0 labels May 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

nielsbauman
nielsbauman reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@nielsbauman nielsbauman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two optional comments and one less optional :D, other than that it LGTM :)

...n/core/src/main/java/org/elasticsearch/xpack/core/datastreams/DataStreamFeatureSetUsage.java Outdated Show resolved Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/datastreams/DataStreamFeatureSetUsage.java Outdated Show resolved Hide resolved
x-pack/plugin/core/src/javaRestTest/java/org/elasticsearch/xpack/core/DataStreamRestIT.java Outdated Show resolved Hide resolved
@gmarouli gmarouli requested a review from nielsbauman May 22, 2024 15:29
nielsbauman
nielsbauman approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmarouli gmarouli merged commit af45653 into elastic:main May 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@nielsbauman nielsbauman nielsbauman approved these changes

Assignees
No one assigned
Labels
:Data Management/Data streams Data streams and their lifecycles >non-issue Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmarouli @elasticsearchmachine @mark-vieira @nielsbauman