Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inference API] Use randomSecureStringOfLength instead of manual construction in test #108904

Merged
merged 1 commit into from
May 22, 2024
Merged

[Inference API] Use randomSecureStringOfLength instead of manual construction in test #108904

merged 1 commit into from
May 22, 2024

Conversation

timgrein
Copy link
Contributor

Saw a small room for improvement while working on Google AI Studio by using randomSecureStringOfLength directly

@timgrein timgrein added >non-issue :ml Machine learning Team:ML Meta label for the ML team v8.15.0 labels May 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

przemekwitek
przemekwitek approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timgrein timgrein merged commit c775230 into elastic:main May 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemekwitek przemekwitek przemekwitek approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timgrein @elasticsearchmachine @przemekwitek