Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable index.mapper.dynamic index setting validation. #109160

Merged
merged 2 commits into from
May 29, 2024
Merged

Disable index.mapper.dynamic index setting validation. #109160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5c0df1
Disable index.mapper.dynamic index setting validation.
martijnvg May 29, 2024
fb35d81
Update docs/changelog/109160.yaml
martijnvg May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/109160.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 109160
summary: Disable `index.mapper.dynamic` index setting validation
area: Mapping
type: bug
issues: []
9 changes: 8 additions & 1 deletion server/src/main/java/org/elasticsearch/index/mapper/MapperService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@

public class MapperService extends AbstractIndexComponent implements Closeable {

private static final DeprecationLogger DEPRECATION_LOGGER = DeprecationLogger.getLogger(MapperService.class);

/**
* The reason why a mapping is being merged.
*/
Expand Down Expand Up @@ -205,7 +207,12 @@ public MapperService(

if (INDEX_MAPPER_DYNAMIC_SETTING.exists(indexSettings.getSettings())
&& indexSettings.getIndexVersionCreated().onOrAfter(Version.V_7_0_0)) {
throw new IllegalArgumentException("Setting " + INDEX_MAPPER_DYNAMIC_SETTING.getKey() + " was removed after version 6.0.0");
DEPRECATION_LOGGER.warn(
DeprecationCategory.MAPPINGS,
"index.mapper.dynamic",
"Setting {} was removed after version 6.0.0",
INDEX_MAPPER_DYNAMIC_SETTING.getKey()
);
}
defaultMappingSource = "{\"_default_\":{}}";
if (logger.isTraceEnabled()) {
Expand Down