Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant BytesQueryBuilder in favour of using WrapperQueryBuilder internally #10919

Closed
wants to merge 1 commit into from
Closed

Remove redundant BytesQueryBuilder in favour of using WrapperQueryBuilder internally #10919

wants to merge 1 commit into from

Commits on May 8, 2015

  1. Java api: remove redundant BytesQueryBuilder in favour of using Wrapp… 

    …erQueryBuilder internally

BytesQueryBuilder was introduced to be used internally by the phrase suggester and its collate feature. It ended up being exposed via Java api but the existing WrapperQueryBuilder could be used instead. Added WrapperQueryBuilder constructor that accepts a BytesReference as argument.

One other reason why this filter builder should be removed is that it gets on the way of the query parsers refactoring, given that it's the only query builder that allows to build a query through java api without having a respective query parser.

Closes elastic#10919
    @javanna
    javanna committed May 8, 2015
    Configuration menu
    Copy the full SHA
    1a70a16 View commit details
    Browse the repository at this point in the history