Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility for asserting listeners are completed #109325

Merged
merged 28 commits into from
Jun 13, 2024
Merged

Add utility for asserting listeners are completed #109325

merged 28 commits into from
Jun 13, 2024

Commits on Jun 4, 2024

  1. Add utility for asserting listeners are completed 

    Closes elastic#108123
    @nicktindall
    nicktindall committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    984e2fd View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @nicktindall
    nicktindall committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1b54b82 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary escaping

    @nicktindall
    nicktindall committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c94c829 View commit details
    Browse the repository at this point in the history

  4. Update server/src/main/java/org/elasticsearch/action/ActionListenerIm… 

    …plementations.java

Co-authored-by: Ievgen Degtiarenko <ievgen.degtiarenko@gmail.com>
    @nicktindall @idegtiarenko
    nicktindall and idegtiarenko committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    99d0e16 View commit details
    Browse the repository at this point in the history

  5. Remove/minimise assertBusy blocks

    @nicktindall
    nicktindall committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    323b6f6 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary System.gc()

    @nicktindall
    nicktindall committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a88ce9f View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1e84c2b View commit details
    Browse the repository at this point in the history

  2. Only test for a single call to onResponse OR onFailure

    @nicktindall
    nicktindall committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    bf99ff0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9171a55 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Use LeakTracker to detect non-completed ActionListeners

    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    b90f16b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    4f0e438 View commit details
    Browse the repository at this point in the history

  3. fix whitespace

    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    83f3145 View commit details
    Browse the repository at this point in the history

  4. Test that assertAtLeastOnce delegates correctly

    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    3507494 View commit details
    Browse the repository at this point in the history

  5. Simplify regex

    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    890df5d View commit details
    Browse the repository at this point in the history

  6. Remove variable

    @nicktindall
    nicktindall committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    df408e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    94ab0e9 View commit details
    Browse the repository at this point in the history

  2. Tidy tests, add tests for LeakTracker

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3fbd9f5 View commit details
    Browse the repository at this point in the history

  3. Tidy up

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    628034f View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary code

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2bc3635 View commit details
    Browse the repository at this point in the history

  5. De-verbose-ify

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    29947e5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ad3a53c View commit details
    Browse the repository at this point in the history

  7. Don't use #runBefore because it changes semantics to exactly-once

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    884238d View commit details
    Browse the repository at this point in the history

  8. LeakTrackerTest improvements

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    344477f View commit details
    Browse the repository at this point in the history

  9. Delete LeakTrackerTests (to introduce in a separate PR)

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3372f44 View commit details
    Browse the repository at this point in the history

  10. Add message to assertLeakDetected

    @nicktindall
    nicktindall committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cbb962e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Update server/src/test/java/org/elasticsearch/action/ActionListenerTe… 

    …sts.java

Co-authored-by: David Turner <david.turner@elastic.co>
    @nicktindall @DaveCTurner
    nicktindall and DaveCTurner committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    076ed95 View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @nicktindall
    nicktindall committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    07f7127 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/108123_add_utility_assert_listeners_comp… 

    …lete
    @nicktindall
    nicktindall committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e45718b View commit details
    Browse the repository at this point in the history