Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE if users_roles file does not exist #109606

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jun 12, 2024

In elasticsearch-users gracefully handle the case where the users file exists, but the users_roles file does not.

In `elasticsearch-users` gracefully handle the case where the
`users` file exists, but the `users_roles` file does not.
@tvernum tvernum added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels Jun 12, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Security Meta label for security team labels Jun 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @tvernum, I've created a changelog YAML for you.

@tvernum
Copy link
Contributor Author

tvernum commented Jun 12, 2024

@elasticsearchmachine test this please

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tvernum
Copy link
Contributor Author

tvernum commented Jun 12, 2024

@elasticmachine update branch

@tvernum tvernum added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 12, 2024
@elasticsearchmachine elasticsearchmachine merged commit b4fdfbb into elastic:main Jun 13, 2024
20 checks passed
@tvernum tvernum deleted the fix/users-tool-npe branch June 13, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants