Fix condition that check for new security index #110228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreden
added
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
jfreden
added
auto-merge
|
Confirmed locally that this fixes the issue but running full-bwc just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a new index, we create it using the version from
IndexVersion.min(IndexVersion.current(), clusterState.nodes().getMaxDataNodeCompatibleIndexVersion()), this means that the created index version will be compatible with all nodes in the cluster.When we want to check if an index was created on the latest version we don't want to include
getMaxDataNodeCompatibleIndexVersionsince we need to make sure that the index contains the latest migration, if it doesn't, we want to run the migration.In the BWC tests, the
getMaxDataNodeCompatibleIndexVersionwill return the index version form7.Xas the "latest" version (which is wrong) and therefore it will skip the migration, instead it should only skip on the very latest version.