Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass over Sparse Vector docs for correctness #110282

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Pass over Sparse Vector docs for correctness #110282

merged 4 commits into from
Jul 2, 2024

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Jun 28, 2024 •
edited
Loading

Docs PR for sparse_vector query:

  • Adds a missing param, query_vector
  • Fixes some formatting errors
  • Removes any remaining legacy pointers to text_expansion query that don't list it as legacy or deprecated.

@github-actions GitHub Actions
Copy link

Documentation preview:

@kderusso kderusso force-pushed the kderusso/pass-over-sparse-vector-docs branch from a59413c to 509b776 Compare June 28, 2024 19:26
@kderusso kderusso added >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Jun 28, 2024
@kderusso kderusso marked this pull request as ready for review June 28, 2024 19:28
@kderusso kderusso changed the title Kderusso/pass over sparse vector docs Pass over Sparse Vector docs for correctness Jun 28, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:SearchOrg)

@kderusso kderusso requested review from a team July 1, 2024 14:41
Mikep86
Mikep86 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kderusso kderusso merged commit 7a1d532 into elastic:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikep86 Mikep86 Mikep86 approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kderusso @elasticsearchmachine @Mikep86