Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aggregations_binary to build and parse #11473

Merged
merged 1 commit into from Jun 4, 2015
Merged

Allow aggregations_binary to build and parse #11473

merged 1 commit into from Jun 4, 2015

Commits on Jun 4, 2015

  1. Aggregations: Allow aggregation_binary to build and parse

    Previously AggregationBuilder would wrap binary_aggregations in an aggregations object which would break parsing. This has been fixed so that for normally specified aggregations there are wrapped in an `aggregations` object, for binary aggregation which have the same XContentType as the builder it will use an `aggregations` field name and use the aggregationsBinary as the value (this will render the same as normal aggregations), and for binary aggregation with a different ContentType from the builder we use an `aggregations_binary` field name and add the aggregationsBinary as a binary value.
    
    Additionally the logic in AggregationParsers needed to be changed as it previously did not parse `aggregations_binary` fields in sub-aggregations. A check has been added for the `aggregations_binary` field name and the binaryValue of this field is used to create a new parser and create the correct AggregatorFactories.
    
    Close #11457
    colings86 committed Jun 4, 2015
    Copy the full SHA
    39a20c3 View commit details
    Browse the repository at this point in the history