Improve exception message when shard has a partial commit (segments_N file) due to prior disk full #11539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led to upgrade 3.x segments_N'
| try (IndexInput input = directory.openInput(si, IOContext.READONCE)) { | ||
| public static boolean indexNeeds3xUpgrading(Directory directory) throws IOException { | ||
| final String segmentsFile = SegmentInfos.getLastCommitSegmentsFileName(directory); | ||
| if (segmentsFile != null) { |
|
looks good |
mikemccand
pushed a commit
that referenced
this pull request
Jun 8, 2015
Improve exception message when shard has a partial commit (segments_N file) due to prior disk full
Closed
clintongormley
added
:Exceptions
and removed
:Core/Infra/Core
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES checks the latest segments_N file to see if it was written by Lucene 3.x and upgrade if so, but if that file is truncated (e.g. 0 bytes) due prior disk full, we now give a confusing "failed to upgrade 3x segments" exception when you likely don't have 3.x segments_N nor segments.
This change just breaks apart the exception handling so we do a better job separating "I could not read the latest segments_N file" from "I did read it and it was ancient (Lucene 3.x) and then when I tried to upgrade it, bad things happened".
Closed #11249