Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Lucene's new TopTermsBlendedFreqScoringRewrite. #12129

Merged
merged 1 commit into from Jul 8, 2015
Merged

Expose Lucene's new TopTermsBlendedFreqScoringRewrite. #12129

merged 1 commit into from Jul 8, 2015

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Jul 8, 2015

This rewrite method is interesting because it computes scores as if all terms
had the same frequencies, which avoids disappointments with ranking when a fuzzy
query ranks typos first given that they are less frequent than the correct term.

@jpountz
Expose Lucene's new TopTermsBlendedFreqScoringRewrite.
8238f49 
This rewrite method is interesting because it computes scores as if all terms
had the same frequencies, which avoids disappointments with ranking when a fuzzy
query ranks typos first given that they are less frequent than the correct term.
@jpountz
Copy link
Contributor Author

jpountz commented Jul 8, 2015

Note that I also cleaned up how rewrite methods are parsed given that constant_score_auto and constant_score_filter have been deprecated in favour of constant_score. And used ParseField instead of if (underscore_case_string.equals(rewriteMethod) || camelCaseString.equals(rewriteMethod)).

@jpountz jpountz mentioned this pull request Jul 8, 2015
Merged
@javanna
Copy link
Member

javanna commented Jul 8, 2015

LGTM

jpountz added a commit that referenced this pull request Jul 8, 2015
@jpountz
Merge pull request #12129 from jpountz/enhancement/expose_blended_rew…
8661ab0 
…rite

Expose Lucene's new TopTermsBlendedFreqScoringRewrite.
@jpountz jpountz merged commit 8661ab0 into elastic:master Jul 8, 2015
@kevinkluge kevinkluge removed the review label Jul 8, 2015
@jpountz jpountz deleted the enhancement/expose_blended_rewrite branch July 8, 2015 14:50
@clintongormley
Copy link

awesome!

@jpountz
Copy link
Contributor Author

jpountz commented Jul 9, 2015

@clintongormley the thanks need to go to @markharwood who did the hard work!

@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpountz @javanna @clintongormley @kevinkluge