Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed SHA calculation in license checker to assume binary files #12154

Closed
wants to merge 1 commit into from
Closed

Changed SHA calculation in license checker to assume binary files #12154

wants to merge 1 commit into from

Conversation

clintongormley
Copy link

Related to #12117

Closes #12118

@clintongormley clintongormley added review :Delivery/Build Build or test infrastructure labels Jul 9, 2015
@rmuir
Copy link
Contributor

rmuir commented Jul 9, 2015

+1!

@rmuir
Copy link
Contributor

rmuir commented Jul 9, 2015

I checked on a windows VM (with all plugins, but not core/ due to tar issues, see below), it works and fixes the checksum issue! thanks!

I think for now, we should just push this one, and keep the checker temporarily disabled on windows because it requires not just perl.exe, but a more complicated setup with unzip.exe and a tar.exe that supports .tar.gz (this one is tricky to find on windows). And I think we should be doing mvn verify builds on windows in jenkins etc, even though we do not today.

Maybe in a followup issue the script could be changed to use http://perldoc.perl.org/Archive/Extract.html or something similar if its generally expected to be bundled with perl?

@clintongormley clintongormley deleted the license_check_on_windows branch July 10, 2015 12:05
@clintongormley
Copy link
Author

Maybe in a followup issue the script could be changed to use http://perldoc.perl.org/Archive/Extract.html or something similar if its generally expected to be bundled with perl?

Archive::Extract is no longer in perl core. I'll have a look for alternatives

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix license verification on windows?
3 participants