Persist all engine failure exceptions #12168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areek
force-pushed
the
persist_engine_failures
branch
from
2c08ad3
to
f3b1ae1
Compare
Currently when an engine fails the shard state file is no longer deleted elastic#11933 and the underlying store is only marked as corrupted for index corruption exceptions. This means that the store can be opened, even after it failed with IOE, OOM exceptions. It would be useful to persist the engine failures that are not due to corruption for inspection, these can be exposed later through elastic#11545
areek
force-pushed
the
persist_engine_failures
branch
from
f3b1ae1
to
6c6d05c
Compare
|
@areek it's greet you are picking it up - I'm on the move now so excuse for me for being brief. I think that non-corruption issue shoulnd't be stored on the store but rather in the shard state file (or some other file next to it). The reason is that the store it self can be shared across machines (shadow replicas FTW), so it feels wrong to mark it as "failed" where it didn't really. Take the case of an OOM - it's the node that failed, not the data. The state file is local to the node, so it's different there. |
|
Closing as now we have |
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an engine fails the shard state file is no longer deleted (see #11933)
and the underlying store is only marked as corrupted for index corruption exceptions.
This means that the store can be opened, even after it failed with IOE, OOM exceptions.
It would be useful to persist the engine failures that are not due to corruption for
inspection, these can be exposed later through #11545