New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless recovery loop with `indices.recovery.file_chunk_size=0Bytes` #12919

Merged
merged 1 commit into from Aug 17, 2015

Conversation

Projects
None yet
3 participants
@s1monw
Contributor

s1monw commented Aug 16, 2015

This is caused by sending the same file to the chunk handler with offset
0 which in-turn opens a new outputstream and waits for bytes. But the next round
will send 0 bytes again with offset 0. This commit adds some checks / validators that those
settings are positive byte values and fixes the RecoveryStatus to throw an IAE if the same file
is opened twice.

@s1monw

This comment has been minimized.

Show comment
Hide comment
Contributor

s1monw commented Aug 16, 2015

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Aug 16, 2015

Contributor

LGTM

Contributor

jpountz commented Aug 16, 2015

LGTM

Endless recovery loop with `indices.recovery.file_chunk_size=0Bytes`
This is caused by sending the same file to the chunk handler with offset
`0` which in-turn opens a new outputstream and waits for bytes. But the next round
will send 0 bytes again with offset 0. This commit adds some checks / validators that those
settings are positive byte values and fixes the RecoveryStatus to throw an IAE if the same file
is opened twice.

@s1monw s1monw merged commit 59f390f into elastic:master Aug 17, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@clintongormley clintongormley added v2.0.0-beta1 and removed v2.0.0 labels Aug 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment