Endless recovery loop with indices.recovery.file_chunk_size=0Bytes
#12919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here are two test that triggered that behavior: |
|
LGTM |
clintongormley
added
the
:Distributed/Recovery
s1monw
force-pushed
the
endless_recovery_loop
branch
from
8f7393e
to
e6e0f09
Compare
This is caused by sending the same file to the chunk handler with offset `0` which in-turn opens a new outputstream and waits for bytes. But the next round will send 0 bytes again with offset 0. This commit adds some checks / validators that those settings are positive byte values and fixes the RecoveryStatus to throw an IAE if the same file is opened twice.
s1monw
force-pushed
the
endless_recovery_loop
branch
from
e6e0f09
to
59f390f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by sending the same file to the chunk handler with offset
0which in-turn opens a new outputstream and waits for bytes. But the next roundwill send 0 bytes again with offset 0. This commit adds some checks / validators that those
settings are positive byte values and fixes the RecoveryStatus to throw an IAE if the same file
is opened twice.