New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging test for filesystem scripts #13262
Packaging test for filesystem scripts #13262
Conversation
a758a69
to
f19f0e3
Compare
Rebased and did a little more cleanup. |
@nik9000 I just had a look to the changes and it looks good to me. Please let me know once conflicts are resolved so that I'll be able to run the tests. |
@@ -82,6 +84,8 @@ setup() { | |||
# Uninstall RPM package | |||
################################## | |||
@test "[RPM] remove package" { | |||
# User installed scripts aren't removed so we'll just get them ourselves | |||
rm -f /etc/elasticsearch/scripts/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use ESSCRIPTS here?
f19f0e3
to
85538f7
Compare
@tlrx ready for review again. First commit is a rebase and the second is updates, some from comments, some from running it over and over again. |
@nik9000 do the tests succeed for you? I encountered various issues, mainly for |
OK, tests now succeed. LGTM then. |
That is the |
Adds a tests for loading scripts from the filesystem for search templates and for search filters. Closes elastic#13184
868e946
to
8d02efd
Compare
Squashed and rebased. Will merge to 2.0, 2.x, and master. Thanks for the review @tlrx! |
…mplate Packaging test for filesystem scripts
Adds a tests for loading scripts from the filesystem for search templates
and for search filters.
Closes #13184