Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging test for filesystem scripts #13262

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 2, 2015

Adds a tests for loading scripts from the filesystem for search templates
and for search filters.

Closes #13184

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v2.1.0 v2.0.0 labels Sep 2, 2015
@nik9000
Copy link
Member Author

nik9000 commented Sep 2, 2015

Ping @tlrx for yet more bats tests. These ones won't merge well with #13083 so we should wait until that is in before rebasing but you can review this for the general principle I guess. Or wait.

@nik9000 nik9000 force-pushed the package_test_for_script_and_template branch from a758a69 to f19f0e3 Compare September 2, 2015 13:28
@nik9000
Copy link
Member Author

nik9000 commented Sep 2, 2015

Rebased and did a little more cleanup.

@tlrx
Copy link
Member

tlrx commented Sep 11, 2015

@nik9000 I just had a look to the changes and it looks good to me.

Please let me know once conflicts are resolved so that I'll be able to run the tests.

@@ -82,6 +84,8 @@ setup() {
# Uninstall RPM package
##################################
@test "[RPM] remove package" {
# User installed scripts aren't removed so we'll just get them ourselves
rm -f /etc/elasticsearch/scripts/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ESSCRIPTS here?

@nik9000 nik9000 force-pushed the package_test_for_script_and_template branch from f19f0e3 to 85538f7 Compare September 14, 2015 15:50
@nik9000
Copy link
Member Author

nik9000 commented Sep 14, 2015

@tlrx ready for review again. First commit is a rebase and the second is updates, some from comments, some from running it over and over again.

@tlrx
Copy link
Member

tlrx commented Sep 16, 2015

@nik9000 do the tests succeed for you? I encountered various issues, mainly for [XX PLUGINS] start elasticsearch with all plugins installed tests

@tlrx
Copy link
Member

tlrx commented Sep 16, 2015

OK, tests now succeed. LGTM then.

@nik9000
Copy link
Member Author

nik9000 commented Sep 16, 2015

@nik9000 do the tests succeed for you? I encountered various issues, mainly for [XX PLUGINS] start elasticsearch with all plugins installed tests

That is the --tries 60 thing I keep adding in. I broke it when I merged something else but it wasn't consistently broken. Master has it so rebasing should get it. I'll do that now.

Adds a tests for loading scripts from the filesystem for search templates
and for search filters.

Closes elastic#13184
@nik9000 nik9000 force-pushed the package_test_for_script_and_template branch from 868e946 to 8d02efd Compare September 16, 2015 14:44
@nik9000
Copy link
Member Author

nik9000 commented Sep 16, 2015

Squashed and rebased. Will merge to 2.0, 2.x, and master. Thanks for the review @tlrx!

nik9000 added a commit that referenced this pull request Sep 16, 2015
…mplate

Packaging test for filesystem scripts
@nik9000 nik9000 merged commit 037a758 into elastic:master Sep 16, 2015
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v2.0.0-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bats tests should create a script and a template on the filesystem and verify that they work
4 participants