Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`simple_query_string` overrides boost coming from lucene #13331

Merged
merged 1 commit into from Sep 4, 2015

Conversation

@javanna
Copy link
Member

javanna commented Sep 3, 2015

SimpleQueryStringParser applies whatever boost the query holds, even if the default 1, to the query obtained from parsing of the query string. that might contain its boost, for instance if it resolved to a simple query like term (single term query against a single field). We should rather multiply the existing boost with the boost set to the query, same as we do in query_string

Relates to #13272

@javanna javanna force-pushed the javanna:fix/simple_query_string_boost branch Sep 3, 2015
@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Sep 4, 2015

LGTM

SimpleQueryStringParser applies whatever boost the query holds, even if the default 1, to the query obtained from parsing of the query string. that might contain its boost, for instance if it resolved to a simple query like term (single term query against a single field). We should rather multiply the existing boost with the boost set to the query, same as we do in query_string

Relates to #13272
Closes #13331
@javanna javanna force-pushed the javanna:fix/simple_query_string_boost branch to bd56137 Sep 4, 2015
javanna added a commit to javanna/elasticsearch that referenced this pull request Sep 4, 2015
SimpleQueryStringParser applies whatever boost the query holds, even if the default 1, to the query obtained from parsing of the query string. that might contain its boost, for instance if it resolved to a simple query like term (single term query against a single field). We should rather multiply the existing boost with the boost set to the query, same as we do in query_string

Relates to elastic#13272
Closes elastic#13331
@javanna javanna merged commit bd56137 into elastic:master Sep 4, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
javanna added a commit that referenced this pull request Sep 4, 2015
SimpleQueryStringParser applies whatever boost the query holds, even if the default 1, to the query obtained from parsing of the query string. that might contain its boost, for instance if it resolved to a simple query like term (single term query against a single field). We should rather multiply the existing boost with the boost set to the query, same as we do in query_string

Relates to #13272
Closes #13331
@javanna javanna removed the review label Sep 4, 2015
@clintongormley clintongormley changed the title Query DSL: simple_query_string overrides boost coming from lucene `simple_query_string` overrides boost coming from lucene Sep 6, 2015
@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015
@clintongormley clintongormley removed the v2.1.0 label Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.