Remove easy uses of setAccessible in tests. #13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't worry, I will fix the rest. But some of those remaining will need a lucene upgrade, we need to add a getter or two for tests to do things cleanly.
rmuir
added
>bug
>test
| @@ -293,6 +293,8 @@ | |||
| <include>org/elasticsearch/common/util/MockBigArrays$*.class</include> | |||
| <include>org/elasticsearch/node/NodeMocksPlugin.class</include> | |||
| <include>org/elasticsearch/node/MockNode.class</include> | |||
| <include>org/elasticsearch/node/MockNode.class</include> | |||
There was a problem hiding this comment.
I committed a fix for this
| // the close() method of a lucene analyzer sets the storedValue field to null | ||
| // we simply check this via reflection - ugly but works | ||
| private void assertLuceneAnalyzersAreNotClosed(Map<PreBuiltAnalyzers, List<Version>> loadedAnalyzers) throws IllegalAccessException, NoSuchFieldException { | ||
| // ensure analyzers are still open by checking there is no ACE |
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Sep 12, 2015
Remove easy uses of setAccessible in tests.
|
I just backported this to 2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't worry, I will fix the rest. But some of those remaining will need a lucene upgrade,
we need to add a getter or two for tests to do things cleanly.