Deprecate NotQueryBuilder #14203
Merged
Deprecate NotQueryBuilder #14203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -773,6 +773,10 @@ public static MissingQueryBuilder missingQuery(String name) { | |||
| return new MissingQueryBuilder(name); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated Use {@link #boolQuery()} instead | |||
There was a problem hiding this comment.
add a reference for the mustNot clause?
|
thanks Christoph, left some minor comments. |
cbuescher
force-pushed
the
deprecate-not
branch
from
7b2c8c7
to
295cd41
Compare
|
LGTM |
|
Thanks, added reference to the must not clause in the deprecation notes. |
This PR deprecates the use of NotQueryBuilder like we did with And- and OrQueryBuilder before. BooleanQueryBuilder is now the only way to combine several filters together, so all uses of the not filter can be replaced with a must_not clause.
cbuescher
force-pushed
the
deprecate-not
branch
from
295cd41
to
c24b733
Compare
|
Also on 2.x with 0127af1 |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the use of NotQueryBuilder like we
did with And- and OrQueryBuilder before. BooleanQueryBuilder
is now the only way to combine several filters together, so all
uses of the not filter can be replaced
with a must_not clause.
Relates to #13761