Check "plugin already installed" before jar hell check. #14207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of a plugin using the deprecated `isolated=false` functionality this will cause confusion otherwise. Closes elastic#14205
|
LGTM |
|
i hate shoving before a release, but i will say the fix is IMO low risk and the error could cause a lot of confusion. I'll push to 2.1+ for now. |
clintongormley
added
>enhancement
:Core/Infra/Plugins
Agreed. |
|
+1 |
|
We'll be testing this manually before releasing 2.0 anyway, and it is a minor change ++ to pushing to 2.0 |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a plugin using the deprecated
isolated=falsefunctionalitythis will cause confusion otherwise.
Closes #14205