Remove cache concurrency level settings that no longer apply #14210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>enhancement
>docs
| @@ -79,7 +79,6 @@ | |||
| @Deprecated | |||
| public static final String DEPRECATED_INDICES_CACHE_QUERY_SIZE = "indices.cache.query.size"; | |||
| public static final String INDICES_CACHE_QUERY_EXPIRE = "indices.requests.cache.expire"; | |||
| public static final String INDICES_CACHE_QUERY_CONCURRENCY_LEVEL = "indices.requests.cache.concurrency_level"; | |||
There was a problem hiding this comment.
++. "Concurrency level" is always 255 now. Kinda.
|
LGTM. |
jasontedor
added a commit
that referenced
this pull request
Oct 20, 2015
…vel-settings Remove cache concurrency level settings that no longer apply
|
Thanks for the review @nik9000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some cache concurrency level settings that were
applicable when the cache was backed by the Guava cache implementation,
but no longer apply with the cache implementation completed in #13717.
Relates #7836, relates #13224, relates #13717