Initialize translog before scheduling the sync to disk #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Translog.current might be null when we call syncNeeded().
| @@ -1480,6 +1485,23 @@ public void run() { | |||
| protected void afterAdd() throws IOException {} | |||
| } | |||
|
|
|||
| public void testTranslogCreateWithSmallSyncInterval() throws IOException, InterruptedException { | |||
There was a problem hiding this comment.
I'm doubting whether we should have the test - i don't think it buys much . A reference to the build failure is enough?
|
good catch. LGTM. Doubting about the extra test. |
|
LGTM too I agree the test is optional but not much of a cost either |
|
what now? remove it or not? |
|
flip a coin |
brwe
force-pushed
the
translog-init-npe
branch
from
9a5aa70
to
8ce42ec
Compare
|
When in doubt - less is better :)
|
|
I flipped a coin but then was too clumsy to catch it...so I tried if we have failures in unit tests without that one and there were many so I decided to remove this test. |
brwe
added a commit
that referenced
this pull request
Jan 11, 2016
Initialize translog before scheduling the sync to disk
clintongormley
added
:Distributed/Distributed
clintongormley
added
:Distributed/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise Translog.current might be null when we call syncNeeded().
I saw this in the log of a failed test here: http://build-us-00.elastic.co/job/es_core_21_metal/326/consoleText
Unfortunately it is not the reason for the test failure.