Make the index property a boolean.
#16161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the split of `string` into `text` and `keyword`, the `index` property can only have two values and should be a boolean.
jpountz
added
>enhancement
:Search Foundations/Mapping
|
Looks good. Maybe add a backcompat test for the old ways that were supported, and see it still works with created version before 3.0? |
| } | ||
| /* Only protected so that string can override it */ | ||
| protected Object indexTokenizeOption(boolean indexed, boolean tokenized) { | ||
| return Boolean.valueOf(indexed); |
There was a problem hiding this comment.
Boxing of primitive booleans always leads to the same references as this is guaranteed by the JLS so the explicit call to Boolean#valueOf is not needed (however the OpenJDK implementation of the boxing conversion here is to just insert a call to Boolean#valueOf but that's just an implementation detail).
If the value
pbeing boxed istrue,false, [...], then letr1andr2be the results of any two boxing conversions ofp. It is always the case thatr1 == r2.
|
@rjernst @jasontedor Thanks for the reviews, I pushed a new commit. |
|
LGTM. |
|
Fixed via 2098608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the split of
stringintotextandkeyword, theindexproperty canonly have two values and should be a boolean.