Move missing() from SortBuilder interface to class #16225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpountz @cbuescher suggested the small change, I made it, would be nice to have someone independent give the final LGTM. Maybe you can help here? |
|
LGTM |
As mentioned by @cbuescher on elastic#16151 this method is really implemented only in the FieldSortBuilder. Moving the method down. Relates to elastic#15178
MaineC
force-pushed
the
enhancement/15178-sort-remove-missing
branch
from
47097f1
to
7b5b0d4
Compare
MaineC
pushed a commit
that referenced
this pull request
Mar 9, 2016
…issing Move missing() from SortBuilder interface to class
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @cbuescher on #16151 this method is really implemented only in
the FieldSortBuilder. Moving the method down.
Relates to #15178