Ingest: move get/put/delete pipeline methods to ClusterAdminClient #16242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>enhancement
review
v5.0.0-alpha1
:Data Management/Ingest Node
|
What remains to be discussed here is what to do with the simulate api. It allows to simulate pipelines, which would mean only retrieving existing ones and executing them. The index api and bulk api allow as well to retrieve pipelines and execute them before indexing. Seems consistent to keep simulate in the |
These methods allow to modify and retrieve the content of pipelines, which are stored in the cluster state. Their actions names were already correct under the category cluster:admin/ingest/pipeline/* , the corresponding methods should be moved under client.admin().cluster() .
javanna
force-pushed
the
enhancement/ingest_actions
branch
from
3fe6a5a
to
1a13022
Compare
|
We have discussed this internally and decided to move simulate pipeline to ClusterAdminClient too. This is ready for review then, @martijnvg can you please have a look? |
|
LGTM |
javanna
added a commit
that referenced
this pull request
Jan 27, 2016
Ingest: move get/put/delete pipeline methods to ClusterAdminClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow to modify and retrieve the content of pipelines, which are stored in the cluster state. Their actions names were already correct under the category
cluster:admin/ingest/pipeline/*, the corresponding methods should be moved underclient.admin().cluster().