Support dots in field names when mapping already exists #17759
Conversation
In 2.0 we began restricting fields to not contains dots in their names. This change adds back part of dots in fieldnames support. Specifically, it allows indexing documents that contain dots in the field names, when the correct corresponding mappers exist. For example, if mappings contain an object field `foo`, and a subfield `bar`, then indexing a document with `foo.bar` will work. see elastic#15951
rjernst
added
:Search Foundations/Mapping
| .field("baz", 789) | ||
| .endObject() | ||
| .endObject().bytes(); | ||
| ParsedDocument doc = mapper.parse("test", "type", "1", bytes); |
There was a problem hiding this comment.
let's check that doc.dynamicMappingsUpdate() is null? (ie. there is no mapping update)
|
LGTM |
|
I noticed this is only tagged for Thoughts or am I missing a way someone can upgrade straight from |
|
@djschny it's looking like it will not be possible to backport this feature to 2.x, as it relies on too many mapping changes that have happened in master.
We will be building a reindex-from-remote solution which would allow importing indices from a 1.x cluster directly into 5.x |
OK so for folks that are anxiously waiting this change and cannot upgrade to 2.x because of it, our recommendation is for them to jump straight to 5.x and either re-index themselves or wait until a 5.x release has the planned "reindex-from-remote" solution? I know you did a great job recently updating the migration plugin for 5.x, if installed in a 1.x cluster will it give recommendations on actions that need to be taken for an upgrade to 5.x? I just want to make sure I advise folks out in the field appropriately since this comes up quite frequently. |
clintongormley
changed the title
clintongormley
changed the title
|
+1 |
@clintongormley Sounds good. Is there an issue for that to which one could subscribe? |
In 2.0 we began restricting fields to not contains dots in their names.
This change adds back part of dots in fieldnames support. Specifically,
it allows indexing documents that contain dots in the field names, when
the correct corresponding mappers exist. For example, if mappings
contain an object field
foo, and a subfieldbar, then indexing adocument with
foo.barwill work.see #15951