Stop using cached component in _analyze API #19929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop calling tokenizer/tokenFilters/chaFilter method of IndexService Add some getAnalysisProvider methods Change SynonymTokenFilterFactory constructor Closes elastic#19827
johtani
added
:Search/Analysis
|
I'll review it! |
| final Map<String, TokenFilterFactory> tokenFilterFactories = buildMapping(false, "tokenfilter", indexSettings, tokenFiltersSettings, Collections.unmodifiableMap(tokenFilters), prebuiltAnalysis.tokenFilterFactories); | ||
| final Map<String, AnalyzerProvider<?>> analyzierFactories = buildMapping(true, "analyzer", indexSettings, analyzersSettings, | ||
| analyzers, prebuiltAnalysis.analyzerProviderFactories); | ||
| return new AnalysisService(indexSettings, analyzierFactories, tokenizerFactories, charFilterFactories, tokenFilterFactories); | ||
| } | ||
|
|
||
|
|
||
| public AnalysisProvider<TokenizerFactory> getTokenizerProvider(String tokenizer, IndexSettings indexSettings) { |
There was a problem hiding this comment.
I think it'd be nice to have javadoc for these so it is clear to the casual observer that they are for building the provider in the context of some index's settings.
|
LGTM - I asked for some javadoc but I'm happy for you to add that javadoc and merge whenever you get the chance! |
Add javadoc some methods Closes elastic#19827
|
@nik9000 Thx for reviewing! I added the javadoc. |
|
Thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop calling tokenizer/tokenFilters/charFilter method of IndexService
Add some getAnalysisProvider methods
Change SynonymTokenFilterFactory constructor
Closes #19827