Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reindex and lang-javascript compatible #19933

Merged
merged 1 commit into from
Aug 11, 2016

Commits on Aug 11, 2016

  1. Make reindex and lang-javascript compatible

    Fixes two issues:
    1. lang-javascript doesn't support `executable` with a `null` `vars`
    parameters. The parameter is quite nullable.
    2. reindex didn't support script engines who's `unwrap` method wasn't
    a noop. This didn't come up for lang-groovy or lang-painless because
    both of those `unwrap`s were noops. lang-javascript copys all maps that
    it `unwrap`s.
    
    This adds fairly low level unit tests for these fixes but dosen't add
    an integration test that makes sure that reindex and lang-javascript
    play well together. That'd make backporting this difficult and would
    add a fairly significant amount of time to the build for a fairly rare
    interaction. Hopefully the unit tests will be enough.
    nik9000 committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    e07e5d6 View commit details
    Browse the repository at this point in the history