Internal: Split disk threshold monitoring from decider #20018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
force-pushed
the
split_disk_threshold
branch
from
893f98d
to
b2c0f2d
Compare
In addition to be an allocation decider, DiskThresholdDecider also monitors the used disk in order to trigger a reroute when the thresholds are crossed. This change splits out the settings for disk thresholds into DiskThresholdSettings, and moves the monitoring to a new DiskThresholdMonitor. DiskThresholdDecider is then in line with other allocation deciders, needing only Settings and ClusterSettings for construction, which will allow deguicing allocation deciders.
| // needed. Also this constructor is only used for tests | ||
| this(settings, new ClusterSettings(settings, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS), EmptyClusterInfoService.INSTANCE, null); | ||
| } | ||
| private DiskThresholdSettings diskThresholdSettings; |
|
great change. Thanks @rjernst. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to be an allocation decider, DiskThresholdDecider also
monitors the used disk in order to trigger a reroute when the thresholds
are crossed. This change splits out the settings for disk thresholds
into DiskThresholdSettings, and moves the monitoring to a new
DiskThresholdMonitor. DiskThresholdDecider is then in line with other
allocation deciders, needing only Settings and ClusterSettings for
construction, which will allow deguicing allocation deciders.