Move cluster.routing.allocation.same_shard.host setting to new settings infrastructure #20046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
changed the title
clintongormley
added
>bug
review
:Core/Infra/Settings
| public static final String SAME_HOST_SETTING = "cluster.routing.allocation.same_shard.host"; | ||
| public static final Setting<Boolean> CLUSTER_ROUTING_ALLOCATION_SAME_HOST_SETTING = | ||
| Setting.boolSetting("cluster.routing.allocation.same_shard.host", false, | ||
| Setting.Property.Dynamic, Setting.Property.NodeScope); |
There was a problem hiding this comment.
I'm unsure if this setting should be dynamic.
There was a problem hiding this comment.
As this setting should usually be only set once, it is probably simpler to leave it non-dynamic (as @jasontedor suggested and as it was before this PR). In case where this must absolutely be updated on a production cluster, rolling restart (of master nodes) with config update is always possible.
There was a problem hiding this comment.
Right. I wondered if it should be dynamic or not.
The reason I made it dynamic is document says it's dynamic.
(and thought making it dynamic maybe useful)
I'll make it non-dynamic.
masaruh
force-pushed
the
same_shard_host_setting
branch
from
67a2bd2
to
1e3678c
Compare
…gs infrastructure Fixes elastic#20045
masaruh
force-pushed
the
same_shard_host_setting
branch
from
1e3678c
to
c7e3653
Compare
|
@jasontedor @ywelsch Made it static (and rebased). Can you review it again? |
|
LGTM |
|
Thanks @s1monw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20045