introduce the JSON Processor #20128
Merged
introduce the JSON Processor #20128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>enhancement
WIP
:Data Management/Ingest Node
talevy
force-pushed
the
jsonprocessor
branch
3 times, most recently
from
1997087
to
2c034ea
Compare
28 tasks
| -------------------------------------------------- | ||
| { | ||
| "json": { | ||
| "field": "my_json_string" |
There was a problem hiding this comment.
Could it be a real JSON string in doc?
talevy
force-pushed
the
jsonprocessor
branch
from
b1775b3
to
911ae8f
Compare
|
@martijnvg mind reviewing this one as well? |
talevy
force-pushed
the
jsonprocessor
branch
from
0f18d35
to
80f2b9c
Compare
| /** | ||
| */ | ||
| public class IngestDocumentMatcher { | ||
| public static void assertIngestDocument(Object a, Object b) { |
There was a problem hiding this comment.
maybe remove the empty jdocs at the class level and add actual jdoc on the method itself?
|
LGTM, assuming build is happy. Left one small comment. |
|
thanks! I will wait for the other PR to merge in so that I can remove this |
talevy
force-pushed
the
jsonprocessor
branch
from
80f2b9c
to
ac38a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20052