Add support for parameters to the script ingest processor #20136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
>enhancement
review
:Data Management/Ingest Node
|
LGTM |
| CompiledScript compiledScript = scriptService.compile(script, ScriptContext.Standard.INGEST, emptyMap()); | ||
| ExecutableScript executableScript = scriptService.executable(compiledScript, vars); | ||
| ExecutableScript executableScript = scriptService.executable(script, ScriptContext.Standard.INGEST, emptyMap()); | ||
| executableScript.setNextVar("ctx", document.getSourceAndMetadata()); |
There was a problem hiding this comment.
looks new. I like this update!
The script processor should support `params` to be consistent with all other script consumers.
imotov
force-pushed
the
enable-params-in-script-processor
branch
from
304f797
to
b36fbc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script processor should support
paramsto be consistent with all other script consumers.