Fix propagating the default value for script settings #20183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
added
>bug
:Core/Infra/Scripting
| defaultIfNothingSet, Property.NodeScope); | ||
|
|
||
| if (langAndTypeSetting.exists(settings)) { | ||
| // fine-grained script.engine.groovy.inline |
There was a problem hiding this comment.
// fine-grained e.g. script.engine.groovy.inline?
|
LGTM. Left a minor thing about a comment. |
Fixes an issue where the value for the `script.engine.<lang>.inline` settings would be _set_ properly, but would not accurately be reflected in the `include_defaults` output. Adds a test to ensure the default raw setting is now correct. Resolves elastic#20159
dakrone
force-pushed
the
prop-script-settings
branch
from
fcdee9c
to
3fbfb3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the value for the
script.engine.<lang>.inlinesettings would be set properly, but would not accurately be reflected
in the
include_defaultsoutput. Adds a test to ensure the default rawsetting is now correct.
Resolves #20159