Source filtering should keep working when the source contains numbers greater than Long.MAX_VALUE.
#20278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>bug
:Search/Search
|
LGTM |
… greater than `Long.MAX_VALUE`. elastic#20278 Currently it does not because our parsers do not support big integers/decimals (on purpose) but we do not have to ask our parser for the number type, we can just ask the jackson parser for a number representation of the value with the right type. Note that I did not add similar tests for big decimals because Jackson seems to never return big decimals, even for decimal values that are out of the range of values that can be represented by doubles. Closes elastic#11508
jpountz
force-pushed
the
fix/source_filtering_bigint
branch
from
191dc07
to
5bfab76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it does not because our parsers do not support big integers/decimals
(on purpose) but we do not have to ask our parser for the number type, we can
just ask the jackson parser for a number representation of the value with the
right type.
Note that I did not add similar tests for big decimals because Jackson seems to
never return big decimals, even for decimal values that are out of the range of
values that can be represented by doubles.
Closes #11508