query_string_query should take term length into consideration when fuzziness is auto #20299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +114,7 @@ public void reset(QueryParserSettings settings) { | |||
| @Override | |||
| Query handleBareFuzzy(String qfield, Token fuzzySlop, String termImage) throws ParseException { | |||
| if (fuzzySlop.image.length() == 1) { | |||
| return getFuzzyQuery(qfield, termImage, Float.toString(fuzzyMinSim)); | |||
There was a problem hiding this comment.
let's remove fuzzyMinSim entirely from this class, it looks unused
There was a problem hiding this comment.
Right. It's not used. But it's super class's field. I'm going to remove a line setting the value.
|
Looks good, I left a suggestion for a cleanup. |
…zziness is auto Fixes elastic#15972
masaruh
force-pushed
the
query_string_fuzzy
branch
from
6df1ac3
to
3a13f54
Compare
|
LGTM |
|
Thanks @jpountz! |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15972