Hardcode painless as the default scripting lang and add legacy script default for stored scripts #20310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
WIP
:Core/Infra/Scripting
| } | ||
|
|
||
| public static String getLegacyDefaultLang(Settings settings) { | ||
| return settings.get("script.legacy.default_lang", ScriptSettings.LEGACY_DEFAULT_LANG); |
There was a problem hiding this comment.
this key is different from the one specified above in https://github.com/elastic/elasticsearch/pull/20310/files#diff-9a1a4781a78e7e7a89657e8717f88997R61
|
I really think we need a test for this. maybe we can build a bwc index with a script in the percolator? Maybe we can even fake it in a unittest and build a lucene index ourself, start an indexservice etc. to test this. Otherwise this looks awesome |
|
I think we can remove the WIP label here too |
|
@s1monw I've updated the PR and replaced the WIP label with review label. |
|
LGTM great solution, good tests, well done! thanks mate! |
martijnvg
force-pushed
the
legacy_scrip_lang_groovy
branch
from
13e42a7
to
2b2bfbc
Compare
…oded default script language. ** The default script language is now maintained in `Script` class. * Added `script.legacy.default_lang` setting that controls the default language for scripts that are stored inside documents (for example percolator queries). This defaults to groovy. ** Added `QueryParseContext#getDefaultScriptLanguage()` that manages the default scripting language. Returns always `painless`, unless loading query/search request in legacy mode then the returns what is configured in `script.legacy.default_lang` setting. ** In the aggregation parsing code added `ParserContext` that also holds the default scripting language like `QueryParseContext`. Most parser don't have access to `QueryParseContext`. This is for scripts in aggregations. * The `lang` script field is always serialized (toXContent). Closes elastic#20122
martijnvg
force-pushed
the
legacy_scrip_lang_groovy
branch
from
2b2bfbc
to
245882c
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script.default_langsetting and madepainlessthe hardcoded default script language.Scriptclass.script.legacy.default_langsetting that controls the default language for scripts that are stored inside documents (for example percolator queries). This defaults to groovy.QueryParseContext#getDefaultScriptLanguage()that manages the default scripting language. Returns alwayspainless, unless loading query/search request in legacy mode then the returns what is configured inscript.legacy.default_langsetting.ParserContextthat also holds the default scripting language likeQueryParseContext. Most parser don't have access toQueryParseContext. This is for scripts in aggregations.langscript field is always serialized (toXContent).PR for #20122
Need to add tests and docs, but before adding those I'd like to get some feedback.