Add "version" field to Pipelines #20343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickypg
added
>enhancement
:Data Management/Ingest Node
|
LGTM |
|
why is |
|
@talevy I didn't want to worry about BWC or returning something that is unset. I think it's easier to just not set it if it's not there. |
|
To be clear, the BWC comment stems from me thinking about how this will work with templates as well. |
|
@pickypg got it |
2 tasks
pickypg
force-pushed
the
feature/add-version-to-pipelines
branch
2 times, most recently
from
d1a4d11
to
0196c8e
Compare
This adds a version field to Pipelines, which is itself is unused by Elasticsearch, but exists for users to better manage their own pipelines.
pickypg
force-pushed
the
feature/add-version-to-pipelines
branch
from
0196c8e
to
6a7309c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
versionfield to Pipelines, which is itself is unused by Elasticsearch, but exists for users to better manage their own pipelines. Likedescription, it's optional.{ "version": 10, "processors": [ ] }This is the pipeline portion of #20171