Validate max thread/merge settings #20383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change checks that `index.merge.scheduler.max_thread_count` < `index.merge.scheduler.max_merge_count` and fails index creation and settings update if the condition is not met. Fixes #20380
jimczi
added
>bug
:Core/Infra/Settings
|
LGTM, thanks @jimferenczi |
|
this LGTM, I wonder if we should do something about this in 2.x as well. We should at least try to not fail write request when settings fail to apply? Catching exceptions in |
|
Thanks @mikemccand and @s1monw |
s1monw
pushed a commit
that referenced
this pull request
Sep 8, 2016
Validate max thread/merge settings
s1monw
pushed a commit
that referenced
this pull request
Sep 8, 2016
Validate max thread/merge settings
jimczi
added a commit
that referenced
this pull request
Sep 8, 2016
Manual backport of #20383 Since settings are not validate in 2.x, this change catch the exception if the merge settings are not valid and do not apply them in the current CMS. The downside is that we'll try to apply the new settings if the index is reopened or if the node is restarted, this will fail and the only solution for the user is to re-update the merge settings back to valid values. Relates #20380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks that
index.merge.scheduler.max_thread_count<index.merge.scheduler.max_merge_countand fails index creationand settings update if the condition is not met.
Fixes #20380