Disable console logging #20387
Merged
Disable console logging #20387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the methods TestLoggers#addAppender and TestLoggers#removeAppenders to the class Loggers as these methods will be needed in production code.
Previously we would disable console logging in certain circumstances (for example, if Elasticsearch is not in the foreground, or if Elasticsearch is in the foreground but an exception was thrown during bootstrap). This commit makes this handling work with Log4j 2. This will prevent users from seeing double bootstrap check failure messages.
jasontedor
added
review
:Core/Infra/Logging
|
retest this please |
1 similar comment
|
retest this please |
|
LGTM |
This commit merely marks the clazz parameter on Loggers#findAppender as final.
This commit adds a unit test for Loggers#findAppender. The idea behind the test is to assert that we find an expected appender (a console appender configured on the test logger), and to assert that we successfully return null when a given appender is not present (a console appender configured on a logger that only has a counting appender).
This commit adds even stronger assertions to the test EvilLoggerTests#testFindAppender.
|
Thanks @jaymode! |
jasontedor
added a commit
that referenced
this pull request
Sep 9, 2016
Previously we would disable console logging in certain circumstances (for example, if Elasticsearch is not in the foreground, or if Elasticsearch is in the foreground but an exception was thrown during bootstrap). This commit makes this handling work with Log4j 2. This will prevent users from seeing double bootstrap check failure messages. Relates #20387
jasontedor
added a commit
that referenced
this pull request
Sep 9, 2016
Previously we would disable console logging in certain circumstances (for example, if Elasticsearch is not in the foreground, or if Elasticsearch is in the foreground but an exception was thrown during bootstrap). This commit makes this handling work with Log4j 2. This will prevent users from seeing double bootstrap check failure messages. Relates #20387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would disable console logging in certain circumstances
(for example, if Elasticsearch is not in the foreground, or if
Elasticsearch is in the foreground but an exception was thrown during
bootstrap). This commit makes this handling work with Log4j 2. This will
prevent users from seeing double bootstrap check failure messages.