Add health status parameter to cat indices API #20393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red).
jasontedor
added
review
:Data Management/CAT APIs
| body: | ||
| settings: | ||
| number_of_shards: "1" | ||
| number_of_replicas: "1" |
There was a problem hiding this comment.
I think this assumes that no rest test runner runs against multiple nodes. I think the some of the client test runners do though, so this index will be green for them.
There was a problem hiding this comment.
That is a very good catch, thank you @javanna.
|
I left a comment around testing, LGTM otherwise |
The cat indices health status test tests that the response can be filtered based on the health status of an index. However, this test was implicitly relying on the fact that there was only one data node. This commit modifies this test to account for the fact that there could be multiple data nodes active in the cluster under test.
|
LGTM thanks @jasontedor |
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2016
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red). Relates #20393
jasontedor
added a commit
that referenced
this pull request
Sep 13, 2016
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red). Relates #20393
|
Thanks @javanna. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a health status parameter to the cat indices API for
filtering on indices that match the specified status (green|yellow|red).