-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health status parameter to cat indices API #20393
Add health status parameter to cat indices API #20393
Conversation
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red).
body: | ||
settings: | ||
number_of_shards: "1" | ||
number_of_replicas: "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this assumes that no rest test runner runs against multiple nodes. I think the some of the client test runners do though, so this index will be green for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very good catch, thank you @javanna.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment around testing, LGTM otherwise |
The cat indices health status test tests that the response can be filtered based on the health status of an index. However, this test was implicitly relying on the fact that there was only one data node. This commit modifies this test to account for the fact that there could be multiple data nodes active in the cluster under test.
LGTM thanks @jasontedor |
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red). Relates #20393
This commit adds a health status parameter to the cat indices API for filtering on indices that match the specified status (green|yellow|red). Relates #20393
Thanks @javanna. |
This commit adds a health status parameter to the cat indices API for
filtering on indices that match the specified status (green|yellow|red).