[Package] Remove bin/lib/modules directories on RPM uninstall/upgrade #20448
Conversation
tlrx
added
review
:Delivery/Packaging
| @@ -76,6 +77,12 @@ if [ "$REMOVE_DIRS" = "true" ]; then | |||
| echo " OK" | |||
| fi | |||
|
|
|||
| if [ -d "$MODULES_DIR" ]; then | |||
There was a problem hiding this comment.
I feel like we should be able to mark the directory in the same way that we mark the lib and rpm/deb should handle that for us?
There was a problem hiding this comment.
I agree - I just don't know how to do with nebula.ospackage. Also, it seems that the current configuration leaves empty directory around like /usr/share/elasticsearch/bin, /usr/share/elasticsearch/lib or /usr/share/elasticsearch/modules.
In the case of modules and if empty directories remains on the filesystem, the plugin service will fail to find plugin descriptor in empty directories like /usr/share/elasticsearch/modules/deprecated-plugin...
That's why I chose this option.
There was a problem hiding this comment.
Ok - it isn't great but lets go with it.
|
LGTM |
tlrx
force-pushed
the
remove-modules-dir
branch
2 times, most recently
from
79636f4
to
ccad888
Compare
|
@nik9000 Thanks for your review! I spent some time trying to figure a better solution using ospackage. It's still a kind of hacky but can you please tell me what you think of it? |
|
Also, it registers the bin, lib, modules and each module directory in the RPM spec so that they are correctly removed (like it was for 2.x rpms). |
|
Much better! LGTM |
clintongormley
changed the title
tlrx
changed the title
…elastic#20448) When uninstalling or upgrading elasticsearch using the RPM package some empty directories remain on the filesystem: /usr/share/elasticsearch/bin /usr/share/elasticsearch/lib /usr/share/elasticsearch/modules /usr/share/elasticsearch/modules/foo Having empty directories in modules can prevent elasticsearch to start after an upgrade: the plugins service expects to find a plugin-descriptor.properties file in every sub directory of modules. This PR cleans things a bit so that these empty directories are removed on upgrade/removal like it was in 2.x.
tlrx
force-pushed
the
remove-modules-dir
branch
from
ccad888
to
3caaafa
Compare
…#20448) When uninstalling or upgrading elasticsearch using the RPM package some empty directories remain on the filesystem: /usr/share/elasticsearch/bin /usr/share/elasticsearch/lib /usr/share/elasticsearch/modules /usr/share/elasticsearch/modules/foo Having empty directories in modules can prevent elasticsearch to start after an upgrade: the plugins service expects to find a plugin-descriptor.properties file in every sub directory of modules. This PR cleans things a bit so that these empty directories are removed on upgrade/removal like it was in 2.x. (cherry picked from commit 3caaafa)
…#20448) When uninstalling or upgrading elasticsearch using the RPM package some empty directories remain on the filesystem: /usr/share/elasticsearch/bin /usr/share/elasticsearch/lib /usr/share/elasticsearch/modules /usr/share/elasticsearch/modules/foo Having empty directories in modules can prevent elasticsearch to start after an upgrade: the plugins service expects to find a plugin-descriptor.properties file in every sub directory of modules. This PR cleans things a bit so that these empty directories are removed on upgrade/removal like it was in 2.x. (cherry picked from commit 3caaafa)
|
Thanks @nik9000! I merged and updated the description of the PR to better reflect the changes. |
When uninstalling or upgrading elasticsearch using the RPM package some empty directories remain on the filesystem:
Having empty directories in
modulescan prevent elasticsearch to start after an upgrade: the plugins service expects to find aplugin-descriptor.propertiesfile in every sub directory ofmodules.This PR cleans things a bit so that these empty directories are removed on upgrade/removal like it was in 2.x.