Remove poor-mans compression in InternalSearchHit and friends #20472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still use some crazy poor mans compression in InternalSearchHit that uses a thread local and an unordered map as a lookup table if requested. Stuff like this should be handeled by compression on the transport layer rather than in-line in the serialization code. This code is complex enough.
| } else { | ||
| out.writeVInt(context.shardHandleLookup().get(shard)); | ||
| } | ||
| if (shard == null) { |
|
left a minor comment, LGTM otherwise |
s1monw
added a commit
that referenced
this pull request
Sep 14, 2016
We still use some crazy poor mans compression in InternalSearchHit that uses a thread local and an unordered map as a lookup table if requested. Stuff like this should be handled by compression on the transport layer rather than in-line in the serialization code. This code is complex enough.
s1monw
added a commit
that referenced
this pull request
Sep 14, 2016
We still use some crazy poor mans compression in InternalSearchHit that uses a thread local and an unordered map as a lookup table if requested. Stuff like this should be handled by compression on the transport layer rather than in-line in the serialization code. This code is complex enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use some crazy poor mans compression in InternalSearchHit that
uses a thread local and an unordered map as a lookup table if requested.
Stuff like this should be handled by compression on the transport layer
rather than in-line in the serialization code. This code is complex enough.