[DOC] Remove obsolete node names from documentation #20524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if the tests pass. CI seems upset. |
|
retest this please |
1 similar comment
|
retest this please |
Funny node names have been removed in elastic#19456 and replaced by UUID. This commit removes these obsolete node names and replace them by real UUIDs in the documentation. closes elastic#20065
tlrx
force-pushed
the
remove-Marvel-node-names
branch
from
0f5a455
to
656596c
Compare
|
Thanks @nik9000 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funny node names have been removed in #19456 and replaced by UUID. This commit removes these obsolete node names and replace them by real UUIDs in the documentation. Remaining mentions in cat/nodes will be removed by #20520.
closes #20065
Note: I wrote a quick shell script to iterate over
names.txtandgrepthe names in asciidoc files. Some of them where really adapted to elasticsearch: