Add production warning for pre-release builds #20674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a usage warning when Elasticsearch is started with a pre-release build.
jasontedor
added
>enhancement
review
:Core/Infra/Core
nik9000
approved these changes
Sep 27, 2016
| @@ -313,6 +313,10 @@ public String toString() { | |||
| return sb.toString(); | |||
| } | |||
|
|
|||
| public String displayVersion() { | |||
There was a problem hiding this comment.
I foresee being confused about whether we should use this or toString. Maybe we should just use toString in this case?
There was a problem hiding this comment.
@nik9000 Version#toString does not display whether or not the build is a snapshot build; I'm happy to add Javadocs?
There was a problem hiding this comment.
Ah! I see the static reference now. I think this method is fairly confusing then? Like, it looks like it is just about the version that you are calling it on but it does stuff with the current build.
There was a problem hiding this comment.
I pushed 0fce68d, I think this will remove the confusion.
nik9000
approved these changes
Sep 27, 2016
This commit moves Version#displayVersion to Node as the method is rather confusing on Version since it relies on a reference to an instance of Version but a static reference to the build.
jasontedor
added a commit
that referenced
this pull request
Sep 28, 2016
This commit adds a usage warning when Elasticsearch is started with a pre-release build. Relates #20674
jasontedor
added a commit
that referenced
this pull request
Sep 28, 2016
This commit adds a usage warning when Elasticsearch is started with a pre-release build. Relates #20674
|
Thanks @nik9000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a usage warning when Elasticsearch is started with a
pre-release build.