IndicesClusterStateService should clean local started when re-assigns an initializing shard with the same aid #20687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an initializing shard with the same aID When a node get disconnected from the cluster and rejoins during a master election, it may be that the new master already has that node in it's cluster and will try to assign it shards. If the node hosts started primaries, the new shards will be initializing and will have the same allocation id as the allocation ids of the current started size. We currently do not recognize this currently. We should clean the current IndexShard instances and initialize new ones. This also hardens test assertions in the same area.
|
retest this please |
ywelsch
approved these changes
Oct 3, 2016
| currentRoutingEntry, newShardRouting); | ||
| indexService.removeShard(shardId.id(), "removing shard (stale copy)"); | ||
| } else if (newShardRouting.initializing() && currentRoutingEntry.active()) { | ||
| logger.debug("{} removing shard (not active, current {}, new {})", shardId, currentRoutingEntry, newShardRouting); |
There was a problem hiding this comment.
can you add a comment here that describes how this situation can occur?
| public MockIndexShard(ShardRouting shardRouting) { | ||
| this.shardRouting = shardRouting; | ||
| public MockIndexShard(ShardRouting shardRouting, long term) { | ||
| this.shardRouting = shardRouting; this.term = term; |
There was a problem hiding this comment.
are we saving some newlines here? 🙄
There was a problem hiding this comment.
I guess it was folded by intellij into a one liner and I just added it in there. Anyway - fixed.
| assertThat(this.shardId(), equalTo(shardRouting.shardId())); | ||
| assertTrue("current: " + this.shardRouting + ", got: " + shardRouting, this.shardRouting.isSameAllocation(shardRouting)); | ||
| if (this.shardRouting.active()) { | ||
| assertTrue("and active shard must state active, current: " + this.shardRouting + ", got: " + shardRouting, |
There was a problem hiding this comment.
I guess this reads "an active shard must stay active"... ;-)
There was a problem hiding this comment.
:) can't get rid of these states.
…tate_stricter_checks
…rd with the same allocation id as a currently started shard.
bleskes
added a commit
that referenced
this pull request
Oct 3, 2016
… an initializing shard with the same aid (#20687) When a node get disconnected from the cluster and rejoins during a master election, it may be that the new master already has that node in it's cluster and will try to assign it shards. If the node hosts started primaries, the new shards will be initializing and will have the same allocation id as the allocation ids of the current started size. We currently do not recognize this currently. We should clean the current IndexShard instances and initialize new ones. This also hardens test assertions in the same area.
bleskes
added a commit
that referenced
this pull request
Oct 3, 2016
… an initializing shard with the same aid (#20687) When a node get disconnected from the cluster and rejoins during a master election, it may be that the new master already has that node in it's cluster and will try to assign it shards. If the node hosts started primaries, the new shards will be initializing and will have the same allocation id as the allocation ids of the current started size. We currently do not recognize this currently. We should clean the current IndexShard instances and initialize new ones. This also hardens test assertions in the same area.
|
thx @ywelsch |
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node get disconnected from the cluster and rejoins during a master election, it may be that the new master already has that node in it's cluster and will try to assign it shards. If the node hosts started primaries, the new shards will be initializing and will have the same allocation id as the allocation ids of the current started size. We currently do not recognize this currently. We should clean the current
IndexShardinstances and initialize new ones.This also hardens test assertions in the same area.